add shellcheck to ci?
do you folks want to run shellcheck over all shell scripts in the repo? it's an easy way to ensure correctness in shell scripts
gitlab documents how they use it in their CI: https://docs.gitlab.com/ee/development/shell_scripting_guide/#linting (i have it at work as well)
i can do these things:
- Add a
lint
stage to.gitlab-ci.yml
that- runs before
test
- runs on
**/*.sh
in the project - initially, is allowed to fail (up to you folks if you want this to immediately block your pipelines)
- runs before
- Update all scripts to make sure the added gitlab ci job passes
example output of shellcheck: https://gitlab.com/-/snippets/3597612
Edited by Zed Tan