Skip to content

Fix macOS ARM compatibility

BobDotCom requested to merge BobDotCom/hunter:master into master

PyQt5 cannot be installed via pip on macOS ARM (m-series chips). This commit avoids installing PyQt5 via pip when possible.

This should not affect other operating systems. There are only two differences:

  1. The PyQt5 requirement now includes a system platform and architecture qualifier - when on macOS ARM it will not be installed. Other platforms are unaffected by this change
  2. The dockerfile now installs PyQt5 via apt-get instead of pip. When the pip install step is reached, pip will see PyQt5 as already installed and will skip the requirement. This goes for all platforms, but shouldn't cause any issues as it doesn't matter where PyQt5 is installed from.

This PR has been fully tested on macOS ARM. It should be tested on one other platform (doesn't matter which) to make sure everything works - but in theory it should be just fine.

Merge request reports