Resolve "Also test for python 3.8"
This MR finally makes it possible to test dantro against python 3.8 -- about time!
As you can see below, this was quite a struggle. It boils down to a conflict between h5py and the netcdf4 package, which xarray used as an engine to write netcdf4 data.
The solution: Don't use the netcdf4 package, but scipy to write the netcdf4 data. This is supported by xarray's to_netcdf4
method.
In effect, we also replace the sometimes problematic and infrequently updated netcdf4 package with a more widely used package, which I would regard as positive.
To document the error and how to handle it, I added an entry to the documentation.
Anything to double-check?
- Documentation ok?
- Any better idea regarding "notes regarding upgrade"?
Can this MR be accepted?
-
Updated dependencies in setup.py
-
Added FAQ entry regarding the encountered error to the documentation -
Tests added or adjusted(no code changes) -
Checked code coverage on new and adjusted code(no code changes) -
Pipeline passes without warnings -
Changelog entry and "notes regarding upgrade" added -
Version number bumped to 0.12.0a2
-
Approved by @herdeanu
Related issues
Closes #92 (closed)
Edited by Utopia Developers