Improve computation time in GraphGroup._get_data_at
requested to merge 209-skip-_combine-in-labelleddatagroup-if-only-one-container-is-selected into master
This MR improves the computation time in GraphGroup._get_data_at (hence for the GraphGroup usage in general) by avoiding some unneccessary computations.
Details
Unneeded .sel() calls can be removed / replaced. This should speed up the computation time wherever .sel() is costly (see #209 (closed)).
Anything to double-check?
Does this lead to a significant speed-up?
Can this MR be accepted?
-
Implementation ready -
Tests added or adjusted(tested and profiled locally, see discussion) -
Documentation extended or updated(not needed)
-
Code quality -
Changes follow coding guidelines -
Checked code coverage on new and adjusted code
-
-
Ready for merging -
Pipeline passes without warnings -
History cleaned-up or squash option set -
Changelog entry added -
Version number bumped -
Reviewed & approved by @herdeanu
-
Related issues
Closes #209 (closed)
Edited by Utopia Developers