Skip to content

Fix uninitialised values and memory leaks

Ghost User requested to merge (removed):v2 into v2

Detected by valgrind.

uninitialised values were due to them being used in onReset before being defined, reordering the variable/functions solves it. the report for this was:

==869036== Conditional jump or move depends on uninitialised value(s)
==869036==    at 0x20F4A6D: Snake::clear_map(int) (snake.cpp:137)
==869036==    by 0x20F4C84: Snake::onReset() (snake.cpp:159)
==869036==    by 0x20F93A5: Snake::Snake() (snake.cpp:654)
==869036==    by 0x2102451: rack::CardinalPluginModel<Snake, SnakeWidget>::createModule() (helpers.hpp:52)
==869036==    by 0x6B39D9: CardinalDISTRHO::CardinalUI::uiIdle() (CardinalUI.cpp:484)
==869036==    by 0x6CA0FA: CardinalDISTRHO::UIExporter::plugin_idle() (DistrhoUIInternal.hpp:248)
==869036==    by 0x6C6368: CardinalDISTRHO::runSelfTests() (DistrhoPluginJACK.cpp:861)
==869036==    by 0x6C65AC: main (DistrhoPluginJACK.cpp:963)
==869036==  Uninitialised value was created by a heap allocation
==869036==    at 0x6E8E013: operator new(unsigned long) (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==869036==    by 0x2102446: rack::CardinalPluginModel<Snake, SnakeWidget>::createModule() (helpers.hpp:52)
==869036==    by 0x6B39D9: CardinalDISTRHO::CardinalUI::uiIdle() (CardinalUI.cpp:484)
==869036==    by 0x6CA0FA: CardinalDISTRHO::UIExporter::plugin_idle() (DistrhoUIInternal.hpp:248)
==869036==    by 0x6C6368: CardinalDISTRHO::runSelfTests() (DistrhoPluginJACK.cpp:861)
==869036==    by 0x6C65AC: main (DistrhoPluginJACK.cpp:963)
==869036==

Merge request reports