Skip to content

Changed the message about the deletion of a grade that appears in the offline...

Dimosthenis Theocharis requested to merge DimosTheocharis/universis-teachers:Issue327-UniqueMessageForGradeDeletion into next

What does this MR do?

This merge request solves the issue #327 (closed) .

Specifically, i changed the message, of the records that symbolize a grade deletion, that gets displayed at the column formattedGrade of the offline table that appears when the user uploads a gradesheet. Previously this message was the same with the message of the records that symbolize a grade update.

This task was done by modified the property code of the validationResult object from 'UPD' to 'DLT' for the records that concern a code deletion. In addition, i had to set a DTL property at the CoursesLocal.GradeStatusTypes object at i18n/courses file, that provides a suitable message.

Before changes:BeforeChanges After changes:AfterChanges

Related issues and links

Fix

Other relevant links

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)
Edited by Dimosthenis Theocharis

Merge request reports