Skip to content

Show accepted values for grades in non numeric grade scales

What does this MR do?

When the grade scale of the course is not numeric (gradeScale !== 0 ), show a warning to the instructor with the accepted values.

To do that, I expand the gradeScale and its value and in the course-grade-modal step 1, I am checking the scale type. If it's 1 or 3 (latin characters, pass/fail), I am showing the accepted values in the format name(alternateName)

This will help users identify possible errors during the grades submission

Related issues and links

Fix #295 (closed)

Screenshot_from_2020-12-17_16-04-03

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)
Edited by Pavlos Karakalidis

Merge request reports