Skip to content

Localized name in dashboard

Closes #557 (closed) #559 (closed)

What does this MR do?

  • Adds localized first name and last name under "Dashboard" in home page.
  • Expands locale field in query to retrieve the full name from student schema.
  • On language change it removes the student value from localStorage.

Change language wasn't implemented the same way on mobile and desktop version. On desktops it was done by calling changeLanguage(lang) function. On mobiles by triggering the onLangChange event. So, I changed the desktop version to trigger that event too and in both cases removeStorageKeys() is called. After that window reloads as before to reflect the changes.

Related issues and links

Fix

Other relevant links

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)
Edited by Theodoros Chatzipouflis-Anninos

Merge request reports