Skip to content

Added a rule that only allows prefetch of availableClasses if department's...

Athanasios Nakas requested to merge athanani/universis-students:improve-available-classes-prefetch into master

What does this MR do?

This MR improves the availableClasses prefetch feature that was introduced with 595. It adds an additional condition that allows prefetch execution, if the time difference between department's registrationPeriodStart and current time is less than the number (in hours) set in prefetchMaximumTimeDifference setting of the configuration file. If the setting is not set then the default number of hours is 2. Of course, the enableAvailableClassesPreFetch setting in the configuration file should be set to true.

E.g. for maximum time of 5 hours the app object in the configuration file should be like the following:

{
  "settings": {
    "app": {
      "enableAvailableClassesPreFetch": true,
      "prefetchMaximumTimeDifference": 5
    }
  }
}

Related issues and links

Fix #570 (closed)

Other relevant links

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)
Edited by Athanasios Nakas

Merge request reports