Skip to content

fix: wrap dining module for production mode

Pavlos Karakalidis requested to merge pkarakal/universis-students:fix-dining-in-prod-mode into master

What does this MR do?

Currently when building the students application in production mode (ng build --prod), the application works correctly apart from the dining request. When you are redirected to #/requests/dining/apply?type=DiningRequest, the route is changed back to the route it had originally instead of being redirected to the dining request form. Even if you force the redirection (eg. you type the entire url) the application redirects you to #/ and a white page is shown. After reading a bit more into it, to lazy load an external module with routing, you have to wrap it around an empty module, so this wraps the dining module with a new module for it to work load correctly both in development and in production mode.

Before these changes the dining module only worked in development mode where build optimizations and ahead of time compilation was disabled.

Related issues and links

Fix

Other relevant links

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)
Edited by Pavlos Karakalidis

Merge request reports