Skip to content

Test profile preview

What does this MR do?

The CI pipeline has been broken for a while now. One of the issues has been addressed in !397 (merged) where the CI couldn't build the application as it wasn't cloning the submodule. Another issue apparently is that the profile-preview-component test has also been broken.

Here I am configuring the module, restructuring the test so that uses spy objects and making some adjustments so that the test is corrected.

I also disabled the test job on the graduation submodule as it also breaks the pipeline job. Once tests have been corrected in the graduation submodule, we can revert the commit

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)

Merge request reports