Skip to content

refactor(registrations): Loading screen is hidden only when the data is ready

What does this MR do?

Here I am making the loading screen persist until the data is ready in the registration components. This way no component elements will be shown while loading. In registration courses I also made some variables public as they are referenced from the component template and if aot build is used, they cannot be referenced.

This came as a production issue when the api was slow to respond. To simulate a slow response, I used the network tools from the browser Dev Tools and throttled my connection to GPRS and I got the result I expected.

Related issues and links

Fix #493 (closed)

Other relevant links

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)

Closes #493 (closed)

Edited by Pavlos Karakalidis

Merge request reports