Skip to content

Use bar diagrams

Pavlos Karakalidis requested to merge pkarakal/universis-students:use-bar-diagrams into master

What does this MR do?

Features:

  • This adds a new interface CourseGradeDistributionBase
  • Creates a new component for visualizing exam grade distribution

Changes:

  • Replaces the custom markup in grades-recent component with the new GradeDistributionModal component
  • Adds grade distribution feature to grades-all component

GradeDistributionModalComponent is a the component that will be responsible for visualizing any grade distribution and is created with a mild abstraction on the data layer as it is component independent and isn't bound to the structure of a particular components variable object. Instead it uses a more generic type CourseGradeDistributionBase and anyone that wants to use it has to first cast their variable to that type.

TODO:

  • Find a sane place to add the grade distribution entrypoint in grades-all component in desktop/tablet mode
  • Implement it there

Related issues and links

Fix

Other relevant links

Screenshot_from_2020-08-31_14-50-10

Screenshot_from_2020-08-08_15-04-05

Screenshot_from_2020-08-08_15-03-50

Screenshot_from_2020-08-31_14-53-53

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)
Edited by Pavlos Karakalidis

Merge request reports