Skip to content

Users are now able to submit an empty registration

What does this MR do?

Users are now able to submit an empty registration. forceNew parameter is getting removed from the getcurrentRegistration function as it is redundant and the catch block should catch the error and initialize the currentRegistration object in the session storage

Here is part of the POST request when I submitted an empty registration which shows that the registration has no classes

Screenshot_from_2019-11-19_16-01-09

Related issues and links

Fix #336 (closed)

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)

Closes #336 (closed)

Edited by Pavlos Karakalidis

Merge request reports