Skip to content

Make the semester popup hide on orientation change.

What does this MR do?

This MR fixes the semester popup at the dashboard.

I added event listeners that close the popup when the screen orientation changes. By doing this, I'm trying to close the popup before before it's parent become display: none. This implementation fixes the problem only at devices that support that event.

See more at: https://caniuse.com/#search=orientationchange

Note: That solution does not work at desktop browser. We need to find another solution, but that should resolve the immediate problem.

Related issues and links

Fix #302 (closed)

Other relevant links

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)
Edited by Dimitrios Pliakos

Merge request reports