Skip to content

refactor(profile): Prevent null values in the date localization pipe.

What does this MR do?

Remove the Elvis Operator from the localizedDate pipe

The Elvis operator returns null when the object does not contain the key that is being tested and the localizedDate produces an error at such case. ignores the input and returns no visual result (the error was produced by my test code logs).

That MR moves the condition test at the template rather than the pipe expression to prevent null values to pass into the pipe.

Related issues and links

References universis#272 (closed)

Other relevant links

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)
Edited by Dimitrios Pliakos

Merge request reports