Alter average grade calculation in all components
What does this MR do?
In this MR, I am using the getGradesSimpleAverage
and getGradesWeightedAverage
from the gradesService introduced in !204 (merged) and using it in
- progress-bar-degree component
- grades-all component both in each group of courses
I am also resolving the case where the student has graduated and the tooltip in the progress bar shows the average grade of the courses and not the degree grade. To achieve it, I am importing the gradeScale service, fetching the graduationGradeScale and using it to transform the degreeGrade .
Related issues and links
Fix #275 (closed) #286 (closed) #294 (closed)
Developer Checklist
-
I have successfully run the code of this merge request locally -
I have verified locally that my changes work for all necessary screen sizes -
I have tried out the changes of this MR with different users to identify bugs -
Coding is in progress, and I have marked the MR as WIP -
Coding is completed and the MR is ready for review -
My branch is up-to-date with the upstream master
branch -
My MR follows the contribution guidelines -
I have added a comment with screenshots of the code running locally
Tech review Checklist
Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?
-
The MR accurately describes the changes and has a relevant title/description -
The MR does what it is supposed to according to its title, description and related issues/links -
I have successfully run the changes locally, and tried the new code
Overall review Checklist
-
The MR references related issues/MRs -
The MR provides links to screens and screenshots -
The commits of the MR describe the changes, have proper wording, and follow the guidelines -
I have successfully run the changes locally, and tried the new code -
The MR is ready for merge (rebased, commit squashed if needed, etc)