Skip to content

Fix requests status styling

What does this MR do?

Changes the styling of the status of a request to be more like the proposal in invision.

  • Remove 5 different divs with repeated classes, move to a single use of ngClass instead.
  • Change color of status to be green when accepted, red when failed or canceled, gray when potential or active.
  • Change the font size of the original request and all the replies.
  • Change color, size and padding of bar to the left.
  • Change color of message depending on whether it is from registrar or user.
  • Move status message to the top right of the card.

Before:

Screenshot_20190828_143503

After:

Screenshot_20190828_152727

Related issues and links

Fix #45 (closed)
Invision screen: https://projects.invisionapp.com/d/main#/console/14789607/317731258/inspect

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)
Edited by George Katsikas

Merge request reports