Further fix tests and provide code coverage report
What does this MR do?
This MR is a continuation of !111 (merged), it aims to:
- Change
npm run testto only run Chrome and not HeadlessChrome too - Fix Chrome running with a sandbox on Linux distros causing browser capture to fail
- Fix all previously commented out tests
- Remove console.log statements on semester-pipe.spec.ts used to debug tests in development phase
- Mock all services to provide an example on how to use spies and set up scaffolding to provide json mock data
- Implement a code coverage reporter
To access the detailed coverage report run npm run test and load /coverage/index.html on your browser.
This has been tested on:
-
Windows -
macOS -
Linux (Manjaro and node:carbon docker image on GitLab CI)
Developer Checklist
-
I have successfully run the code of this merge request locally -
I have verified locally that my changes work for all necessary screen sizes -
I have tried out the changes of this MR with different users to identify bugs -
Coding is in progress, and I have marked the MR as WIP -
Coding is completed and the MR is ready for review -
My branch is up-to-date with the upstream masterbranch -
My MR follows the contribution guidelines -
I have added a comment with screenshots of the code running locally
Tech review Checklist
Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?
-
The MR accurately describes the changes and has a relevant title/description -
The MR does what it is supposed to according to its title, description and related issues/links -
I have successfully run the changes locally, and tried the new code
Overall review Checklist
-
The MR references related issues/MRs -
The MR provides links to screens and screenshots -
The commits of the MR describe the changes, have proper wording, and follow the guidelines -
I have successfully run the changes locally, and tried the new code -
The MR is ready for merge (rebased, commit squashed if needed, etc)