Skip to content

Sidebar fixes

Pavlos Karakalidis requested to merge pkarakal/universis-students:132-sidebar-fixes into universis-theme

What does this MR do?

This MR removes languages from app-sidebar.service.json where they where hard-coded and now get them from the _configurationService.settings.localization.cultures and builds the languages submenu dynamically. To get the native name and code of each language I used npm's package iso-639-1. Also the submenu labels are now translated in users language (universis-teachers#63 (closed))

This MR will also be fixing #132 (closed) , where whenever an event which is an instance of NavigationEnd happens, the sidenav language, items get built again to match the corresponding route. So if we are in /profile, after changing the language, we will be redirect to /profile.

This also adds another path to app.module.ts to match the changes in the URL of the lang-component.

Related issues and links

Fix #132 (closed)

Developer Checklist

  • I have successfully run the code of this merge request locally

  • I have verified locally that my changes work for all necessary screen sizes

  • I have tried out the changes of this MR with different users to identify bugs

  • Coding is in progress, and I have marked the MR as WIP

  • Coding is completed and the MR is ready for review

  • My branch is up-to-date with the upstream master branch

  • My MR follows the contribution guidelines

  • I have added a comment with screenshots of the code running locally

Tech review Checklist

Have you verified that what is supposed to happen, actually does, and what is not supposed to happen, indeed does not?

  • The MR accurately describes the changes and has a relevant title/description
  • The MR does what it is supposed to according to its title, description and related issues/links
  • I have successfully run the changes locally, and tried the new code

Overall review Checklist

  • The MR references related issues/MRs
  • The MR provides links to screens and screenshots
  • The commits of the MR describe the changes, have proper wording, and follow the guidelines
  • I have successfully run the changes locally, and tried the new code
  • The MR is ready for merge (rebased, commit squashed if needed, etc)

Closes #132 (closed)

Edited by Pavlos Karakalidis

Merge request reports