Skip to content

notifyGitlabMrOrCommit: fix missing arg to CommitsApi.addComment()

Ratchanan Srirattanamet requested to merge personal/peat-psuwit/mr-comment-as-a-code-fix-args into main

addComment() (obviously) requires a commit hash to post the comment to. Somehow it went missing, presumably during copy-paste. Without it, the script fails with:

Error when executing always post condition:
groovy.lang.MissingMethodException: No signature of method: org.gitlab4j.api.CommitsApi.addComment() is applicable for argument types: (java.lang.String, java.lang.String) values: [ubports/development/core/cmake-extras, DEB build of UBportsCore/Cmake Extras/main: <b>FIXED</b>.]
Possible solutions: addComment(java.lang.Object, java.lang.String, java.lang.String), addComment(java.lang.Object, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, org.gitlab4j.api.Constants$LineType), getComments(java.lang.Object, java.lang.String)

This is embarassing. 🤦

@mariogrip maybe this is actually what you're seeing?

CC: @sunweaver

Merge request reports