Skip to content

CMakeLists: Drop call of Qt-internal macro

Cosima Neidahl requested to merge OPNA2608/qtmir:fix/dropQtInternalMacroCall into main

Doesn't seem like it really did anything anyway.

In Nixpkgs the call of Qt's internal _populate_Gui_plugin_properties causes issues with our Qt5 patching.

  • Patching the passed path to work with our patches,
  • Changing the path to a complete nonesense one, as well as
  • Removing the call & setting of Qt5Gui_QPA_Plugin_Path entirely

…all seem to produce the same result - both at a quick glance & when comparing results with diffoscope. It seems this doesn't really achieves anything, aside from being an ugly call of an internal macro?

  1. Qt5Gui_QPA_Plugin_Path seems unused in the codebase
  2. The actual Qt plugin install location is determined manually in src/platforms/mirserver/CMakeLists.txt via regular GNUInstallDirs variables

Please let me know if you think this is worth keeping, and what I may be missing about this.

Merge request reports