Skip to content

RE: debian: Change scanout candidate calculation on Mesa

Oren Klopfer requested to merge ook37/mir:personal/ook37/lima into ubports/focal

Whether a buffer is supposed to use scanout capabilities in the driver is determined by it's buffer size. The Lima driver requires scanout buffers to display anything in Mirclient, and since the screen size is 720x1440 it always fails this check, leaving the user with no visible buffers.

Just make sure noone is trying to allocate a negative size for buffers, so that every application can display its content on Mirclient on Lima.

For @fredldotme: I think the fullscreen heuristic misses the vertical buffer case. I think we can either:

  • Also check for width >= 600 && height >= 800, or
  • Just modify the condition to width >= 600 && height >= 600

Which ever you choose is up to you.

I went with the second option: modifying the condition to width >= 600 && height >= 600. This should account for smaller buffer sizes and handle variations in orientation.

Merge request reports