Skip to content

MorphWebView: always treat HTTP error as success

Ratchanan Srirattanamet requested to merge personal/peat-psuwit/qtwebengine-5-15-9 into ubports/xenial

We're upgrading QtWebEngine in UBports to 5.15.9. However, an API break in 5.15.3+ [1] causes us to start displaying our error page for HTTP errors, which breaks sites that return body in the HTTP error. We don't have a good way to detect that, so workaround it by just pretend that the load is successful.

[1] I mean, I'm not sure how Qt tests this kind of thing. This kind of API break is guaranteed not to happen in minor versions, let alone patch version. Alas, we're open source users using mandatory-to- opensource version of QtWebEngine, so what can we say?

https://github.com/qt/qtwebengine/commit/b27edd025dbe6ef2d1e302b8be0e0993ef3d645d

See also: https://gitlab.com/ubports/core/packaging/qtwebengine/-/merge_requests/8#note_912596857

Merge request reports