Skip to content

Add dim background color to select element popup

Marius Gripsgard requested to merge github/fork/giiba/patch-1 into ubports/xenial

Created by: giiba

First, thanks to @lduboeuf for this implementation! This is a great looking way to handle these menus, much easier to interact with than the tiny box that shows up in Demo Browser.

However I am curious why the dimming of the background was disabled? On a white page it makes the select dialogue look very undefined... I think at a minimum there should be a border to define the popup, or just letting the site be dimmed which I personally like.

My suggestion: screenshot20200214_071231219

As exists now: screenshot20200214_074419061

I know there is a slight border, but it doesn't feel like enough. Just a suggestion.

Edited by Chris Clime

Merge request reports