Skip to content

Fix compilation with Qt 5.15.11

Cosima Neidahl requested to merge OPNA2608/lomiri-ui-toolkit:fix/qt51511compat into main

https://github.com/qt/qtdeclarative/commit/48dc55dec2402a425e5370a566b16892abf07a95 changed QV4::CompiledData::Binding::type into a method.

This fixes compilation (together with the other MR that applies the patches from Debian), but there's a new test failure as well:

FAIL!  : tst_UCUnits::gridUnitEnvironmentVariable() Compared doubles are not the same (fuzzy compare)
   Actual   (units.gridUnit()): 8
   Expected (11.0)            : 11
   Loc: [tst_units.cpp(48)]

This is caused by https://github.com/qt/qtbase/commit/533fc55d11710069a83fb35aef5ccab576026978 adding a QPlatformNativeInterface to the minimal platform, meaning the test will take take this branch now and disregard the m_gridUnit it's supposed to pick up via the GRID_UNIT_PX envvar. I don't feel familiar enough with the project to make any change to that.

Edited by Cosima Neidahl

Merge request reports