Skip to content

Draft: Fix version information

The top-level CMakeLists.txt uses custom variables to hold a project version, which is used in

  • the library's version
  • the library's SOVERSION value
  • the pkg-config's Version information

Unfortunately, while the version in the CMake's project() call was set to 0.4, those variables were never adjusted accordingly. So history-service identifies itself as version 0.0.0 everywhere.

To avoid this discrepancy going forward, we replace those custom variables with CMake's PROJECT_VERSION* variables. These parse the version number passed in the project() call.

There is no fallback 0 value for any non-existent component the PROJECT_VERSION doesn't set (i.e. patch & tweak versions on 0.4). I have thus dropped the patch part of the version, to make it match the project's version.


If I misunderstood the point of this second version value (particularly with the way it's applied for the soversion stuff) then feel free to close. This just struck me as odd, maybe something that was missed when the version was tagged.

Edited by Cosima Neidahl

Merge request reports

Loading