Skip to content

Draft: Fix one extra vibration with `rumble` method

Ratchanan Srirattanamet requested to merge personal/peat-psuwit/rumble-no-plusone into main

Fix off-by-one logic in RepeatThread which causes the rumble method to repeat the vibration 1 more than requested in repeat argument.

There is an argument to be made that the argument repeat is exclusive of the initial vibration. However, since we don't allow specifying repeat value of 0, I don't think that makes sense.

Merge request reports