Skip to content

Fix for pubSub not correctly yielding messages received via PSUBSCRIBE

Brendan requested to merge brendanhay/redis-io:feature/psubscribe-fix into develop

The pattern match in the Redis.IO.Client.pubSub evaluator incorrectly discards messages received when using PSUBSCRIBE, as the Data.Redis.Command.readPushMessage from redis-resp returns a PushMessage.PMessage constructor which falls through to the wildcard case.

I've removed the wildcard and instead explicitly match all PushMessage constructors in the pubSub evaluator, and have added an additional parameter to the pubSub callback which is the pattern yielded when a message matches the pattern used with PSUBSCRIBE. This is a breaking change.

Merge request reports