Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • R redis-io
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Toralf Wittner
  • redis-io
  • Merge requests
  • !1

Fix for pubSub not correctly yielding messages received via PSUBSCRIBE

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Brendan requested to merge brendanhay/redis-io:feature/psubscribe-fix into develop Mar 12, 2016
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

The pattern match in the Redis.IO.Client.pubSub evaluator incorrectly discards messages received when using PSUBSCRIBE, as the Data.Redis.Command.readPushMessage from redis-resp returns a PushMessage.PMessage constructor which falls through to the wildcard case.

I've removed the wildcard and instead explicitly match all PushMessage constructors in the pubSub evaluator, and have added an additional parameter to the pubSub callback which is the pattern yielded when a message matches the pattern used with PSUBSCRIBE. This is a breaking change.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/psubscribe-fix