Buffs Tables Stats don't add up
When viewing player stats the total column is nowhere close to the sum of the from items, effects and form columns, which are usually shown as zero.
It looks like this discrepancy comes from how item stats are calculated, e.g.
partial_AllBuffsTable.cshtml
if (Model.HealthBonusPercent() != 0.0M)
{
<tr>
<td>Extra willpower % maximum:</td>
<td>
@Model.HealthBonusPercent().ToString("0")%
</td>
<td class="mobile">@Model.FromForm_HealthBonusPercent.ToString("0")%</td>
<td class="mobile">@Model.FromItems_HealthBonusPercent.ToString("0")%</td>
<td class="mobile">@Model.FromEffects_HealthBonusPercent.ToString("0")%</td>
</tr>
}
FromEffects_HealthBonusPercent
doesn't take into account the stats calculated in the total:
BuffBox.cs
public decimal HealthBonusPercent()
{
float output = 0;
var substat = "HealthBonusPercent"; ;
output += Discipline() * BuffMap.BuffsMap[substat]["Discipline"];
output += Perception() * BuffMap.BuffsMap[substat]["Perception"];
output += Charisma() * BuffMap.BuffsMap[substat]["Charisma"];
output += Fortitude() * BuffMap.BuffsMap[substat]["Fortitude"];
output += Agility() * BuffMap.BuffsMap[substat]["Agility"];
output += Allure() * BuffMap.BuffsMap[substat]["Allure"];
output += Magicka() * BuffMap.BuffsMap[substat]["Magicka"];
output += Succour() * BuffMap.BuffsMap[substat]["Succour"];
output += Luck() * BuffMap.BuffsMap[substat]["Luck"];
output += (float)FromForm_HealthBonusPercent;
output += (float)FromEffects_HealthBonusPercent;
return Convert.ToDecimal(output);
}
The total itself seems OK, but the breakdown is wrong. In particular the item stats parts of the total seems to be incorrectly derived (read from a property instead of calculated).