Rebase / Cherry Pick dialog commit item index is not updated after reordering, causing incorrect behavior when using Shift
What steps will reproduce the problem?
- Create a new local Git repository
- Create four commits (can be "Message only")
Initial
Commit 1
Commit 2
Commit 3
- Use "Show log"
- Right-click commit
Initial
and select "Rebase 'main' onto this" - Check "Force Rebase"
- Select (left-click)
Commit 3
- Press the "Down" button twice
ℹ Commit 3
should now be at the bottom of the commits list - Hold down Shift and left-click
Commit 3
again
❌ All three commits are marked as selected
What is the expected output? What do you see instead?
Expected: When clicking the already selected commit while holding Shift nothing should happen; the commit should stay selected but no other commit should become selected.
Actual: All three commits are selected. It looks like the Rebase dialog did not update the commit 'item index' (in case such concept exists). So after reordering the commits it still thinks that Commit 3
is the top most commit in the list, even though it is now actually the bottom one.
This affects the Cherry Pick dialog as well.
What version of TortoiseGit and Git are you using? On what operating system?
TortoiseGit 2.12.0.0
git version 2.33.0.windows.2
Windows 10
Please provide any additional information below.