Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
TortoiseGit
TortoiseGit
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 303
    • Issues 303
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 9
    • Merge requests 9
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • TortoiseGit
  • TortoiseGitTortoiseGit
  • Issues
  • #3386

Closed
Open
Created May 28, 2019 by Sebastian Zartner@SebastianZ1

Line column in TortoiseGitUDiff might get cut off

What steps will reproduce the problem?

  1. Open a patch with more than 99.999 lines of code or zoom in on a patch with less lines.
  2. Scroll to the bottom of the diff dialog.

What is the expected output? What do you see instead?

The line numbers are clipped at the left edge of the window, because the width of the line column is fixed.

Clipped line column in diff dialog

The width of the column line should be resized based on the width of the last line of the patch.

What version of TortoiseGit and Git are you using? On what operating system?

TortoiseGit: 2.8.2.0
git: 2.18.0.windows.1
OS: Windows 10 Pro with updates from today

Please provide any additional information below.

Having a patch with more than 99.999 lines is obviously an edge case, zooming in is probably more common. I assume it shouldn't be too hard to calculate the width in pixels the last line number requires.

Resizing the column width also has the positive side effect that the user can see a little bit more of the changes on patches with a smaller numer of lines without having to scroll. Alternatively, the column may have a minimal width to provide a consistent look for the common case.

Edited Feb 27, 2020 by Sven Strickroth
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking