You need to sign in or sign up before continuing.
[ENH] RecordRTC has been bundled in Tiki
1 unresolved thread
1 unresolved thread
This merge request bundles the RecordRTC package directly with Tiki, eliminating the need to fetch it as an external dependency. This approach streamlines installation, reduces external dependencies, and ensures RecordRTC is readily available within Tiki.
Key Changes:
- Bundling RecordRTC: Added RecordRTC to Tiki’s npm build system, allowing it to be compiled and deployed as part of the Tiki codebase.
- Deprecating External RecordRTC Package: Marked RecordRTC as deprecated in the Tiki packages configuration with a note indicating it is now bundled with Tiki.
Merge request reports
Activity
added 4 commits
-
7e0e5f8d...18ead987 - 3 commits from branch
tikiwiki:master - 2beea9d5 - Merge branch 'master' into item108348-bundle-recordrtc-with-tiki
-
7e0e5f8d...18ead987 - 3 commits from branch
mentioned in commit 715095bd
81 81 $recordRtcService = new Services_RecordRtc_Controller(); 82 82 $recordRtcService->setUp(); 83 83 84 $recordRtcVendor = VendorHelper::getAvailableVendorPath('recordrtc', 'npm-asset/recordrtc/RecordRTC.js'); 85 if ($prefs['fgal_use_record_rtc_screen'] !== 'y' || empty($recordRtcVendor)) { 86 $smarty->assign('module_error', tra('Record RTC is not available.')); 87 return; 88 } 89 90 84 $headerlib = TikiLib::lib('header'); 91 $headerlib->add_jsfile('vendor/npm-asset/recordrtc/RecordRTC.js', true); @sandy-12 How is this recordrtc loaded now?
Which scenario are you following on https://gitlab.com/tikiwiki/tiki/-/tree/master/src/js. This seems like it's best suited to scenario 1, but it looks like an incomplete implementation of scenario 1.
@benoitg good catch we will fix that.
It has been fixed in MR: !6442 (merged)
mentioned in commit softstart/tikiwiki/tiki@a0054c63
mentioned in merge request !6442 (merged)
Please register or sign in to reply