Skip to content

[bugfix] track blockheight with binance metadata and broadcast bugfix

Son of Odin requested to merge binance-meta-patch into master

[bugfix] track blockheight with binance metadata and detect bad sequence number on broadcast to binance

Noticed two bugs in bifrost.

  1. When updating our binance metadata, we can only do it once per block. So if we have multiple transactions in a single block, its possible to get a bad sequence number on one of them.

  2. When broadcasting to binance chain, we weren't checking the json body for success or not. We've already fixed this in broadcasting to thorchain, just took that code and copied it to binance.

Merge request reports