fix(consensus): BASE block-time constant 2000ms→200ms after Denim
🔎 Visual review of176f1514: explainer, review flags and prompts to ask an AI about the change
Scope (reduced to the consensus constant only)
Base's Denim upgrade (2026-11-05 18:00 UTC) cut the canonical BASE block time from 2s to ~0.2s. common/chain.go's BASEChain.ApproximateBlockMilliseconds() still returned the stale 2_000; this changes it to 200.
Why it is consensus-visible
QuoteSwap is wasm-whitelisted (app/wasm.go), and querier_quotes.go derives the contract-visible InboundConfirmationSeconds from this constant. A CosmWasm contract can read it during tx execution, so a ~24s BASE quote becomes ~2.4s. The change must therefore activate coordinated at the 3.22.0 upgrade height, never via a rolling patch, or binaries diverge on AppHash. Milestone: Release-3.22.0.
Effect on bifrost
Bifrost's node-local ApproximateBlockTime override (already on develop via tn!5336) falls back to this constant when unset. After this change, an unconfigured BASE scanner falls back to 200ms and reads healthy at the post-Denim gap. Without the fix it read unhealthy, so no node would sign BASE. The override still governs the other windows (resume-lag, confirmation waits).
What is intentionally NOT here
- The bifrost scanner health-gate / resume-lag / confirmation-wait fixes and the
default.yamlwindow retuning ship node-local in tn!5336 for 3.21.3 and are not duplicated here. - The 12-block BASE inbound confirmation count is unchanged. Only the per-block time constant moves.
Changes
common/chain.go: constant2_000→200, plus a rationale/consensus comment.common/chain_test.go: asserts200.config/config_test.go: the no-override and invalid-override fallback expectations go from2_000to200.bifrost/blockscanner/blockscanner_extra_test.go:TestBaseScannerUnhealthyWithoutBlockTimeOverridenow asserts the constant is200and that the no-override scanner is healthy. Its comment was updated to match.