chore(review): root CODEOWNERS with 3 approvals on Core paths by default, default MR template
🔎 Visual review of0f5e58ae: explainer, review flags and prompts to ask an AI about the change
Implements #3448 (review policy: three approvals on consensus-critical paths, self-verification).
Target: thorchain/thornode develop
Implements: the review-policy issue (three approvals on consensus-critical paths, self-verification).
Description
- Moves
.gitlab/CODEOWNERSto the repository root as/CODEOWNERS. GitLab reads the root file first, so this is the only ownership file that applies. - Adds a
[Core][3]section owned by thedev-teamhumans plus@huginn-bot. It matches every path and excludes a short list of low-risk paths with!patterns. Any MR touching a non-excluded path needs 3 approvals from 3 different[Core]owners, so at least 2 humans. New paths are[Core]automatically, andCODEOWNERSitself is a[Core]file. - Adds
.gitlab/merge_request_templates/Default.mdwith a self-verification section.
Settings that go with this MR (applied separately by a maintainer, see the issue): no direct pushes to develop and mainnet, protected mainnet-* branches with code owner approval, dev-team on all protected branches, committers cannot approve, bot accounts at the Developer role, protected mainnet* image tags.
| Rule | Branch | Today | After |
|---|---|---|---|
dev-team |
develop |
2 required, includes huginn-bot |
2 required, all protected branches |
CODEOWNERS [Core][3] (new) |
protected branches | n/a | 3 approvals from [Core] owners on every non-excluded path |
devteam-mainnet |
mainnet |
3 required | unchanged |
Wasm Permissions |
develop |
0 + CODEOWNERS [2] |
unchanged |
Known limit: huginn does not approve an MR whose review it marks incomplete (for example binary test data it cannot read). A [Core] MR in that state needs 3 human approvals until huginn can review such files.
Self-verification (to complete on the MR before review)
- MR "Code owners" panel: a file under
x/thorchain/lists the[Core]section and its 8 owners; a file underdocs/lists no[Core]owners. - A throwaway branch adding a new top-level directory shows
[Core]owners for it. .gitlab/CODEOWNERSno longer exists;git ls-files | grep -i codeownersprints onlyCODEOWNERS.
Files
CODEOWNERS (new, repository root; replaces .gitlab/CODEOWNERS)
# Documentation: https://docs.gitlab.com/user/project/codeowners/
# This is the only CODEOWNERS file. GitLab reads /CODEOWNERS before
# docs/CODEOWNERS and .gitlab/CODEOWNERS.
[Wasm Permissions][2]
/common/wasmpermissions/ @NoahSaso @codehans @zefiro576 @snoyberg
# Every path needs 3 approvals from 3 different owners listed here, except the
# exclusions below. huginn-bot is one owner, so that is at least 2 humans.
# New paths are covered automatically. Excluded paths keep the dev-team rule
# (2 approvals). Editing this file is itself a [Core] change.
[Core][3] @son-of-odin @zlyzol @ahdzib @Bitol @starsquid @asaf45 @pratikasr @huginn-bot
*
!/docs/**
!/test/**
!/tools/analyze/**
!/tools/ci-health/**
!/tools/events/**
!/tools/mimir-ids/**
!/tools/p2p-check/**
!/tools/perf/**
!/tools/pubkey2address/**
!/tools/stagenet/**
!/tools/thorscan/**
!/.editorconfig
!/.gitignore
!/.isort.cfg
!/LICENSE
!/README.md
!/bugbounty.md
!/spec.mdNot excluded on purpose (stay [Core]): openapi/ (generated types compiled into the node and Bifrost), .gitattributes (controls diff display), .gitlab-ci.yml, scripts/, build/, REVIEW.md, CLAUDE.md, .claude/, .trunk/, and the tools/ subdirectories evm, gen-keyshare-fixtures, gen-preparams, lint-whitelist-tokens, recover-keyshare-backup.
.gitlab/CODEOWNERS (deleted)
.gitlab/merge_request_templates/Default.md (new)
## What and why
## Self-verification
Commands you ran and the tail of their output. Paste output, not a claim.
- Unit tests for the packages touched:
- Regression / simulation (required if consensus or state code changed):
- Manual check (node, mocknet, replay), if any:
## Risk
- [ ] Changes consensus, state or funds handling
- [ ] Changes Bifrost observation or signing
- [ ] Docs, tests or tooling only
## Rollout
Version gate, mimir, migration, or none.Risk
- No consensus code changes.
CODEOWNERSis read from the target branch, so[Core][3]applies to MRs intodeveloponce this merges, and to release branches once they carry it. - The approval guarantee depends on the settings listed above; they are applied separately, one at a time, each with a rollback.
- Core MRs need one more approval than today. Docs, tests and the excluded tools are unaffected.
- The exclusion list errs toward the high tier. Adding an exclusion is a
[Core]change by construction.