test(observer): restore the 1s state-sync test frame timeout (flake since !5233)
🔎 Visual review of983e02c0: explainer, review flags and prompts to ask an AI about the change
TestStateSyncExportReleaseOnEveryExit (bifrost/observer) has started failing intermittently in its retry step (attestation_state_init_test.go:1733) on develop and on unrelated MRs. It caused 7 of the 20 most recent failed unit-tests jobs on 2026-10-21. It also failed the first scheduled develop pipeline (2973763687), which skipped the deep fuzz and mutation jobs that pipeline exists to run.
Cause
f9de2e16 (!5233 (merged)) cut stateSyncTestFrameTimeout from 1s to 250ms to save time on bifrost/observer. The value also bounds how long the sender waits for the receiver to process each one-item batch, which includes leveldb writes. On a loaded runner that takes longer than 250ms, the sender gives up, and the retry never completes.
Fix
Restore 1s and update the comment, so a later speed pass doesn't shorten it again.
Evidence
The test binary was run with 8 copies in parallel, -count 10 each (560 subtests per round):
| Build | Failed subtests |
|---|---|
| develop | 8, 2, 3 (three rounds) |
| this branch | 0, 0 |
The whole bifrost/observer package passes, both normally and with -race. It takes 94s instead of 78s, about what it took before !5233 (merged).