ci: run the never-executed L1 daemon tests, and track the errata probes

🔎 Visual review of 2a7912e0: explainer, review flags and prompts to ask an AI about the change

An audit of every test added since 2026-09-21, checked against what CI actually executed on develop pipeline 2973095747, found all 623 top-level tests, all 586 gocheck methods, all 8 regression suites and all 5 fuzz targets running. It also found tests that never run. This MR covers those, except the scheduled deep jobs, which need a project pipeline schedule rather than a code change.

1. New job: test-utxo-daemons

Four integration tests skip in every job because they need a real daemon:

Test Needs Why it matters
TestV5Zebra, TestV6Zebra an official zebrad Proves zebrad accepts the transparent v5/v6 ZEC transactions THORChain signs. ZEC outbounds are now signed as v5.
TestDogeStalledBroadcastIsNotDuplicated a mocknet dogecoind no simulation uses Reproduces the duplicate DOGE deposit from job 16347608704.
TestZecIsolatedFunding a mocknet Zebra no simulation uses A lost send response must not create a second payment.

The simulation tests spend from the mocknet master address, so they can't share the simulation's daemons. The job:

  • starts a dogecoind and a Zebra in dind from the mocknet images, entrypoints and settings;
  • copies zebrad out of zfnd/zebra:6.4.2, the image mocknet already runs;
  • runs the new make test-utxo-daemons. That target fails on any skip (--require-test, --max-skips 0), so an unset variable can't pass quietly.

It uses the default trixie Go image, because zebrad 6.4.2 links against trixie's glibc. That rules out the Alpine tools image and the bookworm docker-ce packages. Docker comes from Debian's docker-cli. That package has no buildx, so the job pulls Zebra through the dependency proxy with a plain docker pull and falls back to Docker Hub.

Verified locally:

  • All four tests pass in golang:1.26.10 against zfnd/zebra:6.4.2 and dogecoin-daemon-1.14.9 (Zebra tests about 1.5s, doge 19s, ZEC funding 41s).
  • With the variables unset, make test-utxo-daemons exits 2.
  • glab ci lint, prettier, yamllint, codespell, the test-quality script tests and test-quality-inventory.py --check-selection all pass.

2. Errata probes point at real issues

TestErrataOrderingOrphanedOutboundPermutationsConverge and TestErrataOrderingQueuedErrataCancelsUnexecutedSwap are opt-in (RUN_KNOWN_ERRATA_ISSUES=1). Both still fail on develop, and their skip reason linked !4983 (closed), a closed draft. Each skip now names its own issue:

  • #3298 (existing): an errata in the same proposal leaves the queued swap executable. The orphaned deposit is subtracted from the pool and still pays 99 RUNE at EndBlock. I added the reproducer to the issue.
  • #3431 (new, confidential): with errata first, a late stale outbound observation leaves a permanent 100-unit vault debit (899 vs 999).

Not in this MR

security-fuzz-deep and security-mutations-deep only run on a schedule, and the project had none. A nightly develop schedule is being added in the project settings.

🤖 Generated with Claude Code

Edited by Huginn Ai

Merge request reports

Loading
Loading