ci: run the deep test-quality jobs in every pipeline
🔎 Visual review of2e8fe5ff: explainer, review flags and prompts to ask an AI about the change
What
Run the three deep test-quality jobs in every pipeline instead of only on scheduled ones:
| Job | Added by | Local runtime | Timeout |
|---|---|---|---|
security-mutations-deep |
!5185 (merged) (merged) | 105 s, 7/7 mutants killed | 1h |
accounting-properties-deep (32 seeds) |
!5187 (merged) | 73 s | 30m |
security-fuzz-deep (5 targets × 20 s) |
!5190 (merged) (merged) | 254 s | 1h |
Why
All three were set to $CI_PIPELINE_SOURCE == "schedule", but thorchain/thornode has no pipeline schedules (the last scheduled pipeline ran in 2020), so none of them has ever run. They now use the same *rules as consensus-determinism. They run on the small runners in long-test, alongside the simulation, so they should add about 15 minutes of small-runner time per pipeline without making the pipeline take longer.
Dependencies
Depends on !5187 (merged). !5185 (merged) and !5190 (merged) have merged. This branch contains a merge of test-quality-accounting so accounting-properties-deep exists; once !5187 (merged) merges, the diff shrinks to the rule changes.
Testing
glab ci lintpasses and there are no duplicate top-level job keys.- Ran each deep job's script locally with the CI arguments; all passed (timings above).