Loading
Restore CLAUDE.md and add REVIEW.md
What
CLAUDE.md
Restore CLAUDE.md, which was deleted in the XMR merge (4eba8849). It is rebuilt from the current Makefile, lint scripts and CI config rather than restored from the stale copy:
- Commands table: build,
-tags=mocknetunit tests, gocheck suites, lint, gofumpt format, codegen, regression, simulation, mocknet. - Go toolchain go1.26.9 (from
go.mod/.go-version); Go 1.27 corrupts local regression exports. make lint(diff vsorigin/develop) vs CI'smake lint-ci(whole tree, golangci-lint separate), plus codespell and markdownlint MD049 traps.- Generated-file no-touch list.
- Conventions as of develop: unversioned
validate/handlehandlers (version switching was removed in 37bae506), managers inmanagers.go, migrations inmigration_*.goregistered inmodule.go, constants overrides,version↔️ openapi check. - Consensus gotchas:
gas_usedfeedsLastResultsHash; querier int64 fields are JSON strings; newrepeatedproto fields need anomitemptyjsontag or every export fixture changes. test/simulationis a separate module; go-tss is vendored.- Repository layout (
x/thorchainsubpackages incl.ebifrost, Bifrost chain clients,app-layer, test harnesses), keeper interface + dummy convention, Mimir gating viaGetConfigInt64,_mainnet/_mocknetbuild-tag variant files. - Migrations:
Migrator.MigrateNtoN+1inmigrations*.go, registered inmodule.go. - Pointers into
docs/,REVIEW.md, and the skills that exist on develop.
REVIEW.md (new)
The MR review checklist, as gates:
- Risk level (high / medium / low) from the riskiest file touched, with what each level requires.
- Title and description match the diff.
- At least 80% unit coverage of changed lines, measured by the
unit-testsjob'schanged-coverage.json(orscripts/test-quality-coverage.pylocally). - Regression tests for the happy path and each significant unhappy path, asserting where funds go; Bifrost-only changes use unit + simulation tests instead.
- Scope: flag unrelated edits, drive-by consensus changes, and needless complexity.
- Documentation: a table of change type to the doc that must be updated.
- Specification (
docs/superpowers/specs/, ADRs, linked specs) matches the code. - Consensus and funds safety summary for high-risk MRs, pointing at
blockchain-code-review.
The earlier revision of this MR also committed 10 more skills. They are dropped: they were never on develop, and handler-development / protocol-upgrade document the removed handler version switching. They can come back in a separate MR after they are brought up to date.
Verification
./scripts/trunk check CLAUDE.md REVIEW.md: no issues.- Every path, make target and command in the file was checked against develop at b3af6add, including the coverage tooling REVIEW.md relies on.
- No Go changes.
Edited by Son of Odin