Restore CLAUDE.md and add REVIEW.md

What

CLAUDE.md

Restore CLAUDE.md, which was deleted in the XMR merge (4eba8849). It is rebuilt from the current Makefile, lint scripts and CI config rather than restored from the stale copy:

  • Commands table: build, -tags=mocknet unit tests, gocheck suites, lint, gofumpt format, codegen, regression, simulation, mocknet.
  • Go toolchain go1.26.9 (from go.mod / .go-version); Go 1.27 corrupts local regression exports.
  • make lint (diff vs origin/develop) vs CI's make lint-ci (whole tree, golangci-lint separate), plus codespell and markdownlint MD049 traps.
  • Generated-file no-touch list.
  • Conventions as of develop: unversioned validate/handle handlers (version switching was removed in 37bae506), managers in managers.go, migrations in migration_*.go registered in module.go, constants overrides, version ↔️ openapi check.
  • Consensus gotchas: gas_used feeds LastResultsHash; querier int64 fields are JSON strings; new repeated proto fields need an omitempty jsontag or every export fixture changes.
  • test/simulation is a separate module; go-tss is vendored.
  • Repository layout (x/thorchain subpackages incl. ebifrost, Bifrost chain clients, app-layer, test harnesses), keeper interface + dummy convention, Mimir gating via GetConfigInt64, _mainnet/_mocknet build-tag variant files.
  • Migrations: Migrator.MigrateNtoN+1 in migrations*.go, registered in module.go.
  • Pointers into docs/, REVIEW.md, and the skills that exist on develop.

REVIEW.md (new)

The MR review checklist, as gates:

  1. Risk level (high / medium / low) from the riskiest file touched, with what each level requires.
  2. Title and description match the diff.
  3. At least 80% unit coverage of changed lines, measured by the unit-tests job's changed-coverage.json (or scripts/test-quality-coverage.py locally).
  4. Regression tests for the happy path and each significant unhappy path, asserting where funds go; Bifrost-only changes use unit + simulation tests instead.
  5. Scope: flag unrelated edits, drive-by consensus changes, and needless complexity.
  6. Documentation: a table of change type to the doc that must be updated.
  7. Specification (docs/superpowers/specs/, ADRs, linked specs) matches the code.
  8. Consensus and funds safety summary for high-risk MRs, pointing at blockchain-code-review.

The earlier revision of this MR also committed 10 more skills. They are dropped: they were never on develop, and handler-development / protocol-upgrade document the removed handler version switching. They can come back in a separate MR after they are brought up to date.

Verification

  • ./scripts/trunk check CLAUDE.md REVIEW.md: no issues.
  • Every path, make target and command in the file was checked against develop at b3af6add, including the coverage tooling REVIEW.md relies on.
  • No Go changes.

🤖 Generated with Claude Code

Edited by Son of Odin

Merge request reports

Loading
Loading