fix(bifrost/utxo): send maxfeerate in BTC/kvB, not sats

Problem

sendrawtransaction's maxfeerate argument is denominated in BTC/kvB, not sats. Core parses it with AmountFromValue (BTC → sats) and rejects anything >= 1 BTC/kvB (src/rpc/util.cpp):

CFeeRate ParseFeeRate(const UniValue& json)
{
    CAmount val{AmountFromValue(json)};
    if (val >= COIN) throw JSONRPCError(RPC_INVALID_PARAMETER, "Fee rates larger than or equal to 1BTC/kvB are not accepted");
    return CFeeRate{val};
}

signer.go set maxFee = 10_000_000 and rpc.go puts it straight into args with no conversion, so the wire call is literally sendrawtransaction "<hex>" 10000000 — an assertion of ten million BTC per kvB. Core throws before it ever decodes the transaction, so 100% of BTC and LTC outbounds fail on any node whose daemon has this guard.

The constant was right, the unit was wrong: 10_000_000 sats = 0.1 BTC, which is Core's own default maxfeerate. The fix is that same number in the units the RPC expects.

Why now

Nothing changed on our side — the constant dates to f55a5d8d0f (2023-11-06). The ParseFeeRate guard landed in Bitcoin Core v27.0 (absent v22–v26, present v27/v28/v29).

Operators don't pick a Core version, node-launcher does: 222a8ca7 (2026-07-13, "Bitcoin 29.1") moved bitcoin-daemon 26.2 → 29.1, skipping v27 and v28 in one hop, so no intermediate release ever surfaced this. Every operator who ran make install / make update after 2026-07-13 cannot broadcast BTC. Mainnet outbounds still land only because stragglers on 26.2 carry them — it degrades silently until the last old node upgrades. Stagenet is all-29.1 and shows the endpoint already.

Note on the error

The message names a fee rate, which sends you chasing the transaction's fee — that fee is fine (~6 sat/vB). The rejection is on the argument, and never examines the tx at all.

Testing

Probe with a real, already-confirmed transaction — DecodeHexTx runs before ParseFeeRate in sendrawtransaction, so an undecodable hex always returns -22 TX decode failed and never reaches the fee check.

  • 10000000 → -3 Fee rates larger than or equal to 1BTC/kvB are not accepted
  • 0.1 → passes the fee-rate gate, proceeds to normal tx handling

Merge request reports

Loading
Loading