fix(thorchain): credit gas-agnostic observers in slash accounting (#3081)

An EVM outbound signer makes a pre-broadcast "instant" observation using the gas LIMIT, while the scanner later observes the gas USED. Because these differ, the signer's observation loses gas-sensitive consensus (GetConsensusSigners) and its +1 observation slash point is never refunded -- penalising a node for correctly observing every outbound it signed, and polluting churn-out ranking.

Add GetObserveSigners(), a gas-agnostic sibling of GetConsensusSigners that uses the existing EqualsConsensusIgnoreGas, and use it at the four slash-accounting call-sites (txin and txout, observe and non-observe). Consensus selection for fund movement is unchanged -- only which observers are credited for slash accounting.

Closes #3081 (closed).

Merge request reports

Loading
Loading