Skip to content

[Version-unspecific] Export all pending outbounds in genesis

Multipartite requested to merge Multi/genesis-export-pending-outbounds into develop

[Version-unspecific]

Intended to close #1931 (closed)
'[fix] export all pending outbounds in genesis'
which is relevant for both hard fork and regression test (pending outbound queue) invariants.

Notably, this only exports ObservedTxInVoters for pending outbounds, not already-fulfilled outbounds.

The effect of this change is demonstrated by the diff of gas/outbound-over-max-gas.json , which originates from the unobserved outbound at
https://gitlab.com/thorchain/thornode/-/blob/v1.132.0/test/regression/suites/gas/outbound-over-max-gas.yaml#L106-109

type: check
endpoint: http://localhost:1317/thorchain/queue/outbound
asserts:
  - .|length == 1 # outbound remains in queue

I note that its
type: fail-export-invariants
is still unrelatedly required due to ETH.ETH vaults have 50000001 more than their pool
from known bug #1389
'Pool gas is being double-reimbursed (and double-deducted from gas pool Asset balance) for failed transactions (/all txout bond slashes)'
, intended to be addressed by !2778 .

Merge request reports