Skip to content

Fix fees equal to null on native transaction

Hippocampus requested to merge Hippocampus.web3/thornode:1684-navite-transaction-gas into develop

Fix: #1684

There was a whole discussion about whether or not to save this information since the anteHandler is handling the native fees in this case and for that reason it is not necessary for the handler to know it. This information could theoretically be collected from the transaction events, but since this information is no longer available in the public infrastructure offered by Ninerealms I think that this information should also be saved in order to improve the blockchain usability.

Even if it is only for a purely consultative reason, the fees may not always be the same in the future and I think it is important to be able to go back and know with which native fee each transaction was processed in a easy way. I will make the change and reopen the PR trying to defend this position, I don't know what you think about this Eradius.

Reading opinions in comments 😄

Edited by Hippocampus

Merge request reports