[cleanup] remove deposit refunds #check-lint-warning
Closes #1921 (closed)
Return err
to cosmos on deposit errors, remove refund logic since cosmos will discard store changes on error. Fees are deducted in the ante handler regardless of the handler result.
Consequences:
- we used to take a second fee for the refund outbound, we now just take the base tx fee
- txs which err in these ways will no longer leave behind a dead voter record, so the
/thorchain/tx/<hash>
endpoint will be empty. the/txs/<hash>
endpoint will still work and contain the error info
#check-lint-warning since it doesn't like that I added comments to a versioned function
Massive thanks to @Multipartite for working through the smoketests failures and providing fixes
Edited by akrokr