[Version-unspecific] Instant observations (and their SetSigned) rather than delayed to the end of the processTransactions queue (after any failed transaction RemoveSigned)

[Version-unspecific]

This is intended to close #1837 (closed)
'Failed outbounds not properly removed from ethereum (and evm?) signer cache'
, but alternative or complementary approaches are also welcome.

My full reasoning is here:
#1837 (comment 1728126863)

added chain-client label

mentioned in issue #1837 (closed)

Great find on this race - this is consistent with behavior we'd previously seen where failed transactions can sometimes (but not usually) get retried. Incidentally I have a change in flight for #1829 (closed) that does this as a side effect, but we should still merge this as the new signing behavior I'm adding is enabled via mimir.

Approving since this seems to most easily avoid the race, but also wondering if the best fix (to do in the future, not now) may be to extend OnObservedTxIn to receive a boolean parameter that designates insta-observe and skip adding to the signer cache in those cases.

approved this merge request

changed milestone to %Release-1.127.0

added priority0 label

approved this merge request

added 1 commit

• 277cb4b5 - Feedback: 'defer wg.Done()' simplification

Compare with previous version

resolved all threads

approved this merge request

approved this merge request

approved this merge request

added 6 commits

• 277cb4b5...7ed0dce0 - 4 commits from branch develop
• 8c3a19f2 - Instant observations (and their SetSigned) rather than delayed to the end of...
• 9f7df2c8 - Feedback: 'defer wg.Done()' simplification

Compare with previous version

enabled an automatic merge when the pipeline for 9f7df2c8 succeeds

merged

mentioned in issue mayachain/mayanode#94

mentioned in issue mayachain/mayanode#163