[Version-unspecific] StreamingSwap endpoints' source_asset and target_asset and destination fields

[Version-unspecific]

Intended to close #1764 (closed)
'Add inbound amount/asset and destination to the streaming API response'.

Since showing source_asset, target_asset as well (as I would personally like to see both rather than only one).

As always, feedback is welcome.

For instance, this gets the source_asset from the corresponding MsgSwap,
treating the existing deposit field as the inbound amount,
but by 'inbound amount' does the Issue desire the pre-affiliate-fee inbound amount from GetObservedTxInVoter?

(My own impulse at this time is for the streaming swap endpoints to show only amounts and assets of the swap itself,
rather than amounts or assets that are not taking part in the swap.)

---

Fullnode testing with pruned snapshot height 13545069:

Swap queue context:
https://thornode-v1.ninerealms.com/thorchain/queue/swap?height=13545069

Current code (at time of writing):

https://thornode-v1.ninerealms.com/thorchain/swaps/streaming?height=13545069

https://thornode-v1.ninerealms.com/thorchain/swap/streaming/00B41741B140860AED7A85915802A2F6B940291FB821442D58A8B35E1A40A171?height=13545069

With commit bb62037a instead:

added api label

mentioned in issue #1764 (closed)

changed the description

Awesome, thanks! Yea the current deposit field should be sufficient for the amount, I missed that when creating the issue quickly. The assets added here should give enough to extend the streaming table on https://track.ninerealms.com with the USD amount and the source/target asset will be a convenient addition there too.

Symbolic approve, but could you also add a couple sanity check on the new fields in the regression test (https://gitlab.com/thorchain/thornode/-/blob/develop/test/regression/suites/swaps/streaming-swaps.yaml)?

approved this merge request

added milestone-planning label

marked this merge request as draft

changed the description

added 2 commits

• ee8e3063 - Check input amount
• 884df600 - Regression test update: swaps/streaming-swaps.yaml new fields

Compare with previous version

marked this merge request as ready

changed the description

added 1 commit

• 1c788c98 - Regression test update: swaps/streaming-swaps.yaml variables for consistency checks

Compare with previous version

resolved all threads

approved this merge request

added 10 commits

• f2d69487 - 1 commit from branch develop
• e323d03b - Unit test: StreamingSwapResponse fields check (openapi_test.go)
• e89ab90e - OpenAPI StreamingSwap schema correction: Four required fields
• 80a8f09e - QueryStreamingSwap (unchanged fields)
• b2f42c71 - QueryStreamingSwap three new fields
• a955f5b7 - GetSwapQueueItem for QueryStreamingSwap
• a5056313 - Check input amount
• c3464488 - Regression test update: swaps/streaming-swaps.yaml new fields
• 4bcad944 - Regression test update: swaps/streaming-swaps.yaml variables for consistency checks
• 1dcdaa32 - Regression test update: swaps/streaming-swaps.yaml In field calculation check...

Compare with previous version

added 1 commit

• 367cb723 - Regression test update: swaps/streaming-swaps.yaml In field calculation check...

Compare with previous version

approved this merge request

resolved all threads

approved this merge request

added 19 commits

• 367cb723...eb265800 - 10 commits from branch develop
• d83d6b12 - Unit test: StreamingSwapResponse fields check (openapi_test.go)
• 8db06ffa - OpenAPI StreamingSwap schema correction: Four required fields
• bb5a3f9a - QueryStreamingSwap (unchanged fields)
• 6ba1da37 - QueryStreamingSwap three new fields
• 3837e8ae - GetSwapQueueItem for QueryStreamingSwap
• a287260e - Check input amount
• da20bf73 - Regression test update: swaps/streaming-swaps.yaml new fields
• 8222d489 - Regression test update: swaps/streaming-swaps.yaml variables for consistency checks
• 4937e05d - Regression test update: swaps/streaming-swaps.yaml In field calculation check...

Compare with previous version