[Version-unspecific] StreamingSwap endpoints' source_asset and target_asset and destination fields
[Version-unspecific]
Intended to close #1764 (closed)
'Add inbound amount/asset and destination to the streaming API response'.
Since showing source_asset, target_asset as well (as I would personally like to see both rather than only one).
As always, feedback is welcome.
For instance, this gets the source_asset from the corresponding MsgSwap,
treating the existing deposit field as the inbound amount,
but by 'inbound amount' does the Issue desire the pre-affiliate-fee inbound amount from GetObservedTxInVoter?
(My own impulse at this time is for the streaming swap endpoints to show only amounts and assets of the swap itself,
rather than amounts or assets that are not taking part in the swap.)
Fullnode testing with pruned snapshot height 13545069:
Swap queue context:
https://thornode-v1.ninerealms.com/thorchain/queue/swap?height=13545069
Current code (at time of writing):
https://thornode-v1.ninerealms.com/thorchain/swaps/streaming?height=13545069
With commit bb62037a instead:
