Skip to content

[querier] Mimir v2 api tweaks

Pluto (9R) requested to merge mimir-v2-api-tweaks into develop

PR contains fixes/improvements to allow us to build up tooling around mimir v2

  • creates a new `/thorchain/mimirV2/ids` endpoint that returns the ID, ref, vote key, legacy key, type and number of votes each value has. the purpose of this is to allow the node-launcher or frontends to parse the active mimir v2 votes, and give a lookup for the vote key, which is a bit hard to determine without looking at the code directly. it's response is as follows:
[
  {
    "id": 1,
    "name": "AFFILIATEFEEBASISPOINTSMAXGLOBAL", // relevant when looking at /mimirV2
    "vote_key": "1-GLOBAL", // the actual key that is used when sending the mimir transaction
    "legacy_key": "MAXAFFILIATEFEEBASISPOINTS", // the legacy key that can be found at /mimir
    "type": "Economic", // the type, which can be used to contextualize in UIs
    "votes": { // the number of votes each value has
      "500": 4
    }
  },
  ...
]
  • fixes a bug where `/mimir` endpoint was not respecting values overriden by mimir V2 due to a type case mismatch
  • adds more comments to the reg tests
  • increases reg test validator count to 5 to properly demonstrate diff b/w node mimir supermajority and mimir v2 3-majority
Edited by Pluto (9R)

Merge request reports