Skip to content

[ante] add ante validation to external msg handlers

akrokr requested to merge akh/ante_auth into develop

Adds a subset of validation to the ante handler for all external msg handlers. This is called to gate the mempool (and during deliver), so txs that are doomed to error can be rejected earlier.

Commit history is broken up to be easy to review:

ante handlers (regression tests fixed)

  • calls the validation from ante, fixing the new regression tests

regression tests (fail until next commit)

  • adds tests for all external handlers, currently fail, fixed on next commit

function splitting (no functional changes)

  • in cases where validation is more than a line or two, break the logic into re-usable functions

set_node_keys: check pubkey existence before uniqueness

  • change order of validation, slight perf improvement in rare error case, but also allows cleaner next commit

versioning (no functional changes)

  • though not technically needed except for one case, version everything that's touched to be safe

Merge request reports