[migrate] Reverse BTC Pool Slash and Corresponding Bond Slashes

This should revert the pool and node slashes from transaction 5AC64AC48219456C8701E67CB4E6ACA13495F8A8042EBC0E5B4E9DA9CF963A9B in block 11227005. You can inspect the corresponding transaction events with tci txs events 5AC64AC48219456C8701E67CB4E6ACA13495F8A8042EBC0E5B4E9DA9CF963A9B.

changed milestone to %Release-1.113.0

added migration label

changed title from [migrate] Reverse Pool and Node Slash to [migrate] Reverse BTC Pool Slash and Corresponding Bond Slashes

added 1 commit

• b1068bd2 - [migrate] Reverse Pool and Node Slash

Compare with previous version

added 1 commit

• 272dcbf1 - [migrate] Reverse Pool and Node Slash

Compare with previous version

added 1 commit

• fc27e343 - [migrate] Reverse Pool and Node Slash

Compare with previous version

A question on the specification of provider or not:

The specification I saw earlier in version 1's
https://gitlab.com/thorchain/thornode/-/blob/7c3490e9e009088a7226c98543cebb57dc4c53c5/x/thorchain/manager_store_chaosnet.go#L422-449
looked good in that Adjust wouldn't automatically distribute a node fee to the node operator that way
(whereas Adjust doesn't distribute a node fee for a slash, as there's no surplus);
when I wanted ask why two of the node addresses weren't entirely grouped together, I saw that in
https://gitlab.com/thorchain/thornode/-/blob/fc27e343084b38b22fe44e5ac6e28d4a6e238915/x/thorchain/manager_store_chaosnet.go#L438-454
(the most recent commit at time of writing)
the provider specification appears to have been removed.
Could I ask why?

if you look at slashAndUpdateNodeAccount it only slashes the node bond, not bond providers. So we shouldn't need to adjust providers at all, just the node bond.

Ahh. Indeed, if Adjust has not been called since that block (which I think it should not have been since no churn block after then and hopefully no refundBond call) then that should be the case; thank you.

approved this merge request

Confirmed all numbers from source events.

approved this merge request

merged